On 29/07/2024 13:04, Umang Jain wrote: > Mention the reset-gpio polarity in the device tree bindings. > It is GPIO_ACTIVE_LOW according to the datasheet. > > Signed-off-by: Umang Jain <umang.jain@xxxxxxxxxxxxxxxx> > --- IdeasOnBoard folks are seasoned developers, although I noticed from time to time you do not cc all necessary addresses. I wonder why? Something is missing in internal guideline? That's not the first case, but pasting same form letter is a bit annoying, especially considering that *tools tell you to do correct stuff* and you do not need *person to tell you that*. <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time. Please kindly resend and include all necessary To/Cc entries. </form letter> Best regards, Krzysztof
