Re: [PATCH] media: imx335: Fix reset-gpio handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sakari

On 29/07/24 1:11 pm, Sakari Ailus wrote:
Hi Umang,

Thanks for the patch.

On Mon, Jul 29, 2024 at 11:35:35AM +0530, Umang Jain wrote:
The imx335 reset-gpio is initialised with GPIO_OUT_LOW during probe.
Should it be initialised to high instead, to enable reset?

This initialization matches the physical line status, which is low in this case.

I think you should also add a Fixes: tag to this and Cc: stable.

ack
However, the reset-gpio logical value is set to 1 in during power-on
and to 0 on power-off. This is incorrect as the reset line
cannot be high during power-on and low during power-off.

Rectify the logical value of reset-gpio so that it is set to
0 during power-on and to 1 during power-off.

Signed-off-by: Umang Jain<umang.jain@xxxxxxxxxxxxxxxx>





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux