On Mon, Jul 29, 2024, at 09:03, Sakari Ailus wrote:
>> To make it consistent with the other IPU drivers as well as avoid this warning,
>> change the 'select' into 'depends on'.
>
> Thanks for the patch. I'm not sure how I managed to miss the IPU6 driver...
The driver was only adding in 6.10, so your patch was correct
at the time.
> I think we also need, besides IPU_BRIDGE, || !IPU_BRIDGE, as the IPU_BRIDGE
> has additional dependencies (I2C) compared to VIDEO_INTEL_IPU6. I'll add
> that while applying. Please let me know if you have concerns.
Makes sense, yes. I went with a hard dependency since that stays
close to the current version with the select. I tried build-testing
IPU6 now with IPU_BRIDGE=n and I2C=n/I2C=m, which works fine.
However, the testing showed that IPU6 also missed a 'select AUXILIARY_BUS',
which I had not found in randconfig testing because that usually gets
selected by one of is other 30 users.
Since you are changing my patch already, maybe you can also add
that at the same time. Thanks,
Arnd
