Hi, Laurent Thanks for your comments. > Hi Changhuang, > > Thank you for the patch. > > On Tue, Jul 09, 2024 at 01:38:24AM -0700, Changhuang Liang wrote: > > Add ISP output parameters and 3A statistisc collection data video > > device for documents. > > > > Signed-off-by: Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx> > > --- > > .../admin-guide/media/starfive_camss.rst | 11 +++++++--- > > .../media/starfive_camss_graph.dot | 22 > +++++++++++-------- > > 2 files changed, 21 insertions(+), 12 deletions(-) > > > > diff --git a/Documentation/admin-guide/media/starfive_camss.rst > > b/Documentation/admin-guide/media/starfive_camss.rst > > index ca42e9447c47..020f1969e67f 100644 > > --- a/Documentation/admin-guide/media/starfive_camss.rst > > +++ b/Documentation/admin-guide/media/starfive_camss.rst > > @@ -58,15 +58,20 @@ The media controller pipeline graph is as follows: > > :alt: starfive_camss_graph.dot > > :align: center > > > > -The driver has 2 video devices: > > +The driver has 4 video devices: > > > > +- output_params: The meta output device, transmitting the parameters > > +to ISP > > + module. > > - capture_raw: The capture device, capturing image data directly from a > sensor. > > - capture_yuv: The capture device, capturing YUV frame data processed > > by the > > - ISP module > > + ISP module. > > +- capture_scd: The meta capture device, capturing 3A statistics > > +collection data > > Renaming "scd" to "stats" (here and through the whole series) would make > the code and documentation easier to understand for third parties, as it's not > immediately clear what "scd" means. I won't insist too much if this would > cause lots of issues. > Agreed, I will change this. Regards, Changhuang
