Re: Can you make a new v4l-utils release?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Gregor,

On 22/07/2024 12:16, Hans Verkuil wrote:
> On 22/07/2024 11:16, Hans Verkuil wrote:
>> On 22/07/2024 10:28, Hans Verkuil wrote:
>>> On 19/07/2024 23:19, Gregor Jasny wrote:
>>>> Hello Hans,
>>>>
>>>> On 19.07.24 08:19, Hans Verkuil wrote:
>>>>> Hi Gregor,
>>>>>
>>>>> The last v4l-utils release is over half a year ago, and Nicolas would like to
>>>>> have a new release that includes the new v4l2-tracer utility.
>>>>>
>>>>> Do you have time to prepare a new release?
>>>>
>>>> I released and tagged 1.28.0.
>>>>
>>>> While preparing the updated Debian package I wondered if I could safely switch from Qt5 to Qt6. Do you see any blockers?
>>>
>>> Unfortunately, I just tested this and the colors are all wrong with Qt6.
>>>
>>> Also, qvidcap dumps core, even with Qt5.
>>
>> This I just fixed in commit f09b2c091d90228547433f11f94015b9ecfeff13.
>>
>> I believe that this has always been wrong, it just surfaced for the first
>> time due to other changes.
>>
>> Now that qvidcap works again I see that qvidcap produces the correct colors, but qv4l2
>> doesn't (that's with Qt6, Qt5 is fine).
>>
>> I'll try to find out what the difference is, hopefully it is easy.
> 
> Another commit fixing a crash: 60e4ac8949f034120c1c1820f210c7f70a85f2d9
> This too needs to be backported to the 1.28 branch.

Sorry, that was the wrong commit SHA (I looked in the wrong tree).

I now have a fix for Qt6 pushed (even though it is not perfect).

So please port the following three commits to the 1.28 branch:

f09b2c091d90 ("qvidcap: fix core dump")
e268a7229866 ("qv4l2: fix crash when disabling openGL")
69b3a7618cb5 ("qv4l2: always set m_haveFramebufferSRGB to false")

With those committed you can make a new release that should work with
Qt6.

Apologies for not noticing before that Qt6 qv4l2 support was broken.

Regards,

	Hans

> 
> Still looking at the openGL issues in qv4l2.
> 
> Regards,
> 
> 	Hans
> 
>>
>> Regards,
>>
>> 	Hans
>>
>>>
>>> I'm looking that the core dump issue, but Qt6 support probably needs to be
>>> disabled until I have time to figure out what is going on with the colors.
>>>
>>> I'll keep you updated.
>>>
>>> Regards,
>>>
>>> 	Hans
>>>
>>
>>
> 





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux