Hi Ishikawa-san, Thank you for the patch. On Tue, Jul 09, 2024 at 09:08:44AM +0900, Yuji Ishikawa wrote: > Adds the Toshiba Visconti VIIF specific metadata format > > - V4L2_META_FMT_VISCONTI_VIIF_PARAMS for ISP parameters > - V4L2_META_FMT_VISCONTI_VIIF_STATS for ISP statistics > > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@xxxxxxxxxxxxx> This patch looks fine. Assuming the corresponding documentation patch is fine too, Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > Changelog v10: > - add entry for V4L2_META_FMT_VISCONTI_VIIF_PARAMS > - add entry for V4L2_META_FMT_VISCONTI_VIIF_STATS > > Changelog v11: > - no change > > include/uapi/linux/videodev2.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > index 4e91362da6..562038f144 100644 > --- a/include/uapi/linux/videodev2.h > +++ b/include/uapi/linux/videodev2.h > @@ -858,6 +858,10 @@ struct v4l2_pix_format { > /* Vendor specific - used for RaspberryPi PiSP */ > #define V4L2_META_FMT_RPI_BE_CFG v4l2_fourcc('R', 'P', 'B', 'C') /* PiSP BE configuration */ > > +/* Vendor specific - used for Visconti VIIF sub-system */ > +#define V4L2_META_FMT_VISCONTI_VIIF_PARAMS v4l2_fourcc('V', 'I', 'F', 'P') /* ISP Params */ > +#define V4L2_META_FMT_VISCONTI_VIIF_STATS v4l2_fourcc('V', 'I', 'F', 'S') /* ISP Stats */ > + > #ifdef __KERNEL__ > /* > * Line-based metadata formats. Remember to update v4l_fill_fmtdesc() when -- Regards, Laurent Pinchart