Hi Changhuang, kernel test robot noticed the following build warnings: [auto build test WARNING on media-tree/master] [also build test WARNING on linuxtv-media-stage/master staging/staging-testing staging/staging-next staging/staging-linus linus/master v6.10 next-20240718] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Changhuang-Liang/media-cadence-csi2rx-Support-runtime-PM/20240718-131216 base: git://linuxtv.org/media_tree.git master patch link: https://lore.kernel.org/r/20240718032834.53876-2-changhuang.liang%40starfivetech.com patch subject: [PATCH v2 1/5] media: cadence: csi2rx: Support runtime PM config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20240718/202407182235.kxDoVX8T-lkp@xxxxxxxxx/config) compiler: s390-linux-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240718/202407182235.kxDoVX8T-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202407182235.kxDoVX8T-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> drivers/media/platform/cadence/cdns-csi2rx.c:739:12: warning: 'csi2rx_runtime_resume' defined but not used [-Wunused-function] 739 | static int csi2rx_runtime_resume(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~ >> drivers/media/platform/cadence/cdns-csi2rx.c:720:12: warning: 'csi2rx_runtime_suspend' defined but not used [-Wunused-function] 720 | static int csi2rx_runtime_suspend(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~ vim +/csi2rx_runtime_resume +739 drivers/media/platform/cadence/cdns-csi2rx.c 719 > 720 static int csi2rx_runtime_suspend(struct device *dev) 721 { 722 struct csi2rx_priv *csi2rx = dev_get_drvdata(dev); 723 unsigned int i; 724 725 reset_control_assert(csi2rx->sys_rst); 726 clk_disable_unprepare(csi2rx->sys_clk); 727 728 for (i = 0; i < csi2rx->max_streams; i++) { 729 reset_control_assert(csi2rx->pixel_rst[i]); 730 clk_disable_unprepare(csi2rx->pixel_clk[i]); 731 } 732 733 reset_control_assert(csi2rx->p_rst); 734 clk_disable_unprepare(csi2rx->p_clk); 735 736 return 0; 737 } 738 > 739 static int csi2rx_runtime_resume(struct device *dev) 740 { 741 struct csi2rx_priv *csi2rx = dev_get_drvdata(dev); 742 unsigned int i; 743 int ret; 744 745 ret = clk_prepare_enable(csi2rx->p_clk); 746 if (ret) 747 return ret; 748 749 reset_control_deassert(csi2rx->p_rst); 750 751 for (i = 0; i < csi2rx->max_streams; i++) { 752 ret = clk_prepare_enable(csi2rx->pixel_clk[i]); 753 if (ret) 754 goto err_disable_pixclk; 755 756 reset_control_deassert(csi2rx->pixel_rst[i]); 757 } 758 759 ret = clk_prepare_enable(csi2rx->sys_clk); 760 if (ret) 761 goto err_disable_pixclk; 762 763 reset_control_deassert(csi2rx->sys_rst); 764 765 return ret; 766 767 err_disable_pixclk: 768 for (; i > 0; i--) { 769 reset_control_assert(csi2rx->pixel_rst[i - 1]); 770 clk_disable_unprepare(csi2rx->pixel_clk[i - 1]); 771 } 772 773 reset_control_assert(csi2rx->p_rst); 774 clk_disable_unprepare(csi2rx->p_clk); 775 776 return ret; 777 } 778 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
