Re: [PATCH] media: v4l2-core: v4l2-ioctl: missing ', ' in create_bufs logging

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Greetings,

On 17.07.2024 11:58, Hans Verkuil wrote:
The v4l_print_create_buffers() function was missing a ', ' in
the pr_cont call, leading to logs like this:

[93293.533425] video0: VIDIOC_CREATE_BUFS: index=0, count=0, memory=dmabuf, capabilities=0x00000297, max num buffers=32type=vid-cap, width=0, height=0, pixelformat=.... little-endian (0x00000000),
field=any, bytesperline=0, sizeimage=0, colorspace=0, flags=0x0, ycbcr_enc=0, quantization=0, xfer_func=0

Signed-off-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>

LGTM.

Reviewed-by: Sebastian Fricke <sebastian.fricke@xxxxxxxxxxxxx>

Regards,
Sebastian

---
drivers/media/v4l2-core/v4l2-ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
index 5eb4d797d259..64c3e79d6378 100644
--- a/drivers/media/v4l2-core/v4l2-ioctl.c
+++ b/drivers/media/v4l2-core/v4l2-ioctl.c
@@ -484,7 +484,7 @@ static void v4l_print_create_buffers(const void *arg, bool write_only)
{
	const struct v4l2_create_buffers *p = arg;

-	pr_cont("index=%d, count=%d, memory=%s, capabilities=0x%08x, max num buffers=%u",
+	pr_cont("index=%d, count=%d, memory=%s, capabilities=0x%08x, max num buffers=%u, ",
		p->index, p->count, prt_names(p->memory, v4l2_memory_names),
		p->capabilities, p->max_num_buffers);
	v4l_print_format(&p->format, write_only);
--
2.43.0






[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux