On Thu, Jul 04, 2024 at 05:29:59PM +0100, Conor Dooley wrote: > On Thu, Jul 04, 2024 at 03:36:41PM +0200, Julien Stephan wrote: > > From: Phi-bang Nguyen <pnguyen@xxxxxxxxxxxx> > > > > This adds the bindings, for the ISP3.0 camsv module embedded in > > some Mediatek SoC, such as the mt8365 > > > > Signed-off-by: Phi-bang Nguyen <pnguyen@xxxxxxxxxxxx> > > Link: https://lore.kernel.org/r/20230807094940.329165-4-jstephan@xxxxxxxxxxxx > > Another confusing link tag, why is it here? > > > +examples: > > + - | > > + #include <dt-bindings/interrupt-controller/arm-gic.h> > > + #include <dt-bindings/interrupt-controller/irq.h> > > + #include <dt-bindings/clock/mediatek,mt8365-clk.h> > > + #include <dt-bindings/memory/mediatek,mt8365-larb-port.h> > > + #include <dt-bindings/power/mediatek,mt8365-power.h> > > + > > + soc { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + camsv1: camsv@15050000 { > > Didn't Krzysztof already comment about the node name here? > Additionally, the "camsv1" label doest appear to be used, so should be > dropped. You're right about the label, it should be dropped. Regarding the name, as far as I understand, Krzysztof was fine with specific names when no generic alternative can be easily found, which I think is the case here. If my understanding is incorrect, could someone help finding a better name ? > > + compatible = "mediatek,mt8365-camsv"; > > + reg = <0 0x15050000 0 0x0040>, > > + <0 0x15050208 0 0x0020>, > > + <0 0x15050400 0 0x0100>; > > + interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_LOW>; > > + clocks = <&camsys CLK_CAM>, > > + <&camsys CLK_CAMTG>, > > + <&camsys CLK_CAMSV0>; > > + clock-names = "cam", "camtg", "camsv"; > > + iommus = <&iommu M4U_PORT_CAM_IMGO>; > > + power-domains = <&spm MT8365_POWER_DOMAIN_CAM>; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + port@0 { > > + reg = <0>; > > + camsv1_endpoint: endpoint { > > + remote-endpoint = <&seninf_camsv1_endpoint>; > > + }; > > + }; > > + }; > > + }; > > + }; > > +... > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 6bd7df1c3e08..9ac8c08ba692 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -14163,6 +14163,7 @@ M: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > M: Julien Stephan <jstephan@xxxxxxxxxxxx> > > M: Andy Hsieh <andy.hsieh@xxxxxxxxxxxx> > > S: Supported > > +F: Documentation/devicetree/bindings/media/mediatek,mt8365-camsv.yaml > > F: Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml > > > > MEDIATEK SMI DRIVER -- Regards, Laurent Pinchart
