On Mon, Jun 24, 2024 at 10:18:08AM GMT, Jagadeesh Kona wrote: > For Venus V6 variant SoCs(sm8250, sc7280), the venus driver uses the newly > introduced dev_pm_genpd_set_hwmode() API to switch the vcodec GDSC to > HW/SW control modes at runtime. Hence use HW_CTRL_TRIGGER flag for vcodec > GDSC's on sm8250, sc7280 to register the set_hwmode_dev & get_hwmode_dev > callbacks for vcodec GDSC and allow the GDSC mode to be changed using > dev_pm_genpd_set_hwmode() API. > > Signed-off-by: Jagadeesh Kona <quic_jkona@xxxxxxxxxxx> > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx> > Reviewed-by: Taniya Das <quic_tdas@xxxxxxxxxxx> Acked-by: Bjorn Andersson <andersson@xxxxxxxxxx> Regards, Bjorn > --- > drivers/clk/qcom/videocc-sc7280.c | 2 +- > drivers/clk/qcom/videocc-sm8250.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/qcom/videocc-sc7280.c b/drivers/clk/qcom/videocc-sc7280.c > index 317b325d6daf..88c90853cf6e 100644 > --- a/drivers/clk/qcom/videocc-sc7280.c > +++ b/drivers/clk/qcom/videocc-sc7280.c > @@ -240,7 +240,7 @@ static struct gdsc mvs0_gdsc = { > .name = "mvs0_gdsc", > }, > .pwrsts = PWRSTS_OFF_ON, > - .flags = HW_CTRL | RETAIN_FF_ENABLE, > + .flags = HW_CTRL_TRIGGER | RETAIN_FF_ENABLE, > }; > > static struct gdsc mvsc_gdsc = { > diff --git a/drivers/clk/qcom/videocc-sm8250.c b/drivers/clk/qcom/videocc-sm8250.c > index d7e0c32284c1..df479a69cddd 100644 > --- a/drivers/clk/qcom/videocc-sm8250.c > +++ b/drivers/clk/qcom/videocc-sm8250.c > @@ -293,7 +293,7 @@ static struct gdsc mvs0_gdsc = { > .pd = { > .name = "mvs0_gdsc", > }, > - .flags = HW_CTRL, > + .flags = HW_CTRL_TRIGGER, > .pwrsts = PWRSTS_OFF_ON, > }; > > @@ -302,7 +302,7 @@ static struct gdsc mvs1_gdsc = { > .pd = { > .name = "mvs1_gdsc", > }, > - .flags = HW_CTRL, > + .flags = HW_CTRL_TRIGGER, > .pwrsts = PWRSTS_OFF_ON, > }; > > -- > 2.43.0 >