Hi Andy, thank you for the reviews. On 6/3/24 9:36 PM, Andy Shevchenko wrote: > On Mon, Jun 03, 2024 at 03:20:55PM +0200, Hans de Goede wrote: >> The atomisp firmwares have been added to upstream linux-firmware >> under intel/ipu/ add this prefix to the firmware name passed >> to request_firmware(). >> >> Fall back to the old location if this fails to avoid breaking existing >> setups. > > ... > >> + /* Fallback to old fw_path with "intel/ipu/" prefix */ >> + if (rc) >> + rc = request_firmware(&fw, strrchr(fw_path, '/') + 1, isp->dev); > > Perhaps kbasename() ? Ack, changed while merging the patch. Regards, Hans