Hi Dan,
On 2024-06-19 09:21, Dan Carpenter wrote:
> On Tue, Jun 18, 2024 at 07:46:32PM +0000, Jonas Karlman wrote:
>> +static u32 rkvdec_enum_decoded_fmt(struct rkvdec_ctx *ctx, int index,
>> + enum rkvdec_image_fmt image_fmt)
>> {
>> const struct rkvdec_coded_fmt_desc *desc = ctx->coded_fmt_desc;
>> + unsigned int i, j;
>>
>> if (WARN_ON(!desc))
>> return 0;
>>
>> - if (index >= desc->num_decoded_fmts)
>> - return 0;
>> + for (i = 0, j = 0; i < desc->num_decoded_fmts; i++) {
>> + if (rkvdec_image_fmt_match(desc->decoded_fmts[i].image_fmt,
>> + image_fmt) &&
>> + index == j++)
>
> I really don't care for this j++ which is tucked inside a condition.
>
>> + return desc->decoded_fmts[i].fourcc;
>> + }
>
> int fmt_idx = -1;
> unsigned int i;
>
> for (i = 0, i < desc->num_decoded_fmts; i++) {
> if (!rkvdec_image_fmt_match(desc->decoded_fmts[i].image_fmt,
> image_fmt))
> continue;
> fmt_idx++;
> if (index == fmt_idx)
> return desc->decoded_fmts[i].fourcc;
> }
>
> return 0;
>
>>
>> - return desc->decoded_fmts[index];
>> + return 0;
>> }
>
> Don't resend if this is the only issue, but if you do resend could you
> get rid of the j++?
Thanks, I will send a v6 later today/tomorrow and will include your
proposed change.
Regards,
Jonas
>
> regards,
> dan carpenter
