[PATCH] libdvbv5: dvbv3 stats fallback in dvb-fe.c uses wrong value

Marko Lukat <mlukat@xxxxxxxx> · Wed, 26 Jun 2024 14:00:58 +0200

Hi,

having been tasked with getting some old-style devices (it930x based) to 
work in one of our products, I couldn't figure out why tools like 
dvbv5-zap kept showing nonsensical error block count values (UCB). Turns 
out that the v3 fallback code uses the SNR value instead when storing 
the UCB value.

diff --git a/lib/libdvbv5/dvb-fe.c b/lib/libdvbv5/dvb-fe.c
index 7848fcda..4ff9eee0 100644
--- a/lib/libdvbv5/dvb-fe.c
+++ b/lib/libdvbv5/dvb-fe.c
@@ -1520,7 +1520,7 @@ dvbv3_fallback:
                scale = FE_SCALE_NOT_AVAILABLE;
        else
                scale = FE_SCALE_COUNTER;
-       dvb_fe_store_stats(parms, DTV_STAT_ERROR_BLOCK_COUNT, scale, 0, snr);
+       dvb_fe_store_stats(parms, DTV_STAT_ERROR_BLOCK_COUNT, scale, 0, ucb);
 
        if (parms->p.verbose > 1) {
                dvb_log(_("Status: "));

HTH,
Marko








