Hi Dorcas, On 24/06/2024 11:52, Dorcas Anono Litunya wrote: > Hello, > > This series sets up loopback support for video, sliced VBI data and > HDMI CEC across multiple instances in the vivid test driver. It also > updates documentation to reflect changes made. > > The first 7 patches do not implement the actual work but are necessary for > setting up the next changes. They address documentation issues, > fix a g_edid bug, resolve a vivid crash when no outputs are configured, > and add the instance number to the video input and output enumerations. > > The 8th patch adds the controls and infrastructure needed to enable > loopback across multiple instances. > The 9th patch enables the video looping code and CEC support. > The 10th update documentation to reflect all changes made. Thank you very much for all your work on this during your Outreachy internship! It was a lot more complex than we initially anticipated, so I am very pleased to see this patch series. It's a really nice improvement to the vivid driver, making the emulation of S-Video and HDMI much more realistic. It was a pleasure for me and Johan to mentor you. Thank you! Hans > > Dorcas Anono Litunya (3): > media: Documentation: vivid.rst: Remove documentation for Capture > Overlay > media: vivid: Add 'Is Connected To' menu controls > documentation: media: vivid: Update documentation on vivid loopback > support > > Hans Verkuil (7): > media: Documentation: vivid.rst: fix confusing section refs > media: Documentation: vivid.rst: drop "Video, VBI and RDS Looping" > media: Documentation: vivid.rst: add supports_requests > media: vivid: vidioc_g_edid: do not change the original input EDID > media: vivid: don't set HDMI TX controls if there are no HDMI outputs > media: vivid: add instance number to input/output names > media: vivid: loopback based on 'Connected To' controls > > Documentation/admin-guide/media/vivid.rst | 185 +++++-------- > drivers/media/test-drivers/vivid/vivid-cec.c | 88 ++++-- > drivers/media/test-drivers/vivid/vivid-core.c | 250 ++++++++++++++--- > drivers/media/test-drivers/vivid/vivid-core.h | 125 ++++++++- > .../media/test-drivers/vivid/vivid-ctrls.c | 262 ++++++++++-------- > .../test-drivers/vivid/vivid-kthread-cap.c | 86 +++--- > .../media/test-drivers/vivid/vivid-vbi-cap.c | 5 +- > .../media/test-drivers/vivid/vivid-vid-cap.c | 115 +++++--- > .../media/test-drivers/vivid/vivid-vid-cap.h | 2 + > .../test-drivers/vivid/vivid-vid-common.c | 134 ++++++--- > .../test-drivers/vivid/vivid-vid-common.h | 5 +- > .../media/test-drivers/vivid/vivid-vid-out.c | 25 +- > 12 files changed, 859 insertions(+), 423 deletions(-) >