Hi Sebastian On 21/06/24 18:07, Sebastian Fricke wrote: > Hey Devarsh, > > This doesn't compile without errors for me, curious, it probably did > compile without problems for you right? > > drivers/media/platform/imagination/e5010-jpeg-enc.c:1622:19: error: > initialization of ‘int (*)(struct platform_device *)’ from incompatible > pointer type ‘void (*)(struct platform_device *)’ > [-Werror=incompatible-pointer-types] > 1622 | .remove = e5010_remove, > | ^~~~~~~~~~~~ > drivers/media/platform/imagination/e5010-jpeg-enc.c:1622:19: note: (near > initialization for ‘e5010_driver.remove’) > cc1: some warnings being treated as errors > Yes I think it did compile fine for me. Did you try this on tip of linux-next ? As mentioned in changelog, there was update in platform driver for return type of remove function which got changed to void return type. Please check if you have this patch [1] in your tree which got recently merged. Kindly let me know if you still face any issues. [1]: https://lore.kernel.org/all/20240527083416.1177106-2-u.kleine-koenig@xxxxxxxxxxxxxx/ Regards Devarsh
