Re: [PATCH v1 0/9] media: vimc improvements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/24/24 17:57, Laurent Pinchart wrote:
Hello,

This patch series cleans up and improves the vimc driver, with the end
goal of converting it to the V4L2 subdev active state API. The goal of
this exercise is to make the API used by a virtual test driver, to
increase test coverage.

The series starts with 4 random cleanups, to avoid unnecessary
iterations (1/9), constify structures (2/9 and 3/9) and rename a
weirdly-named enum (4/9). Patch 5/9 then centralizes the subdev
internal_ops initialization to prepare for the switch to the active
state API. The remaining patches (6/9 to 9/9) convert the vimc entities
to the new API one by one.

The result has been tested using the libcamera unit tests, which make
extensive use of the vimc driver, as well as with v4l2-compliance. The
latter reports 4 errors, but they occur already with the latest stage
master branch.

Laurent Pinchart (9):
   media: vimc: Don't iterate over single pad
   media: vimc: Constify vimc_ent_type structures
   media: vimc: Constify the ent_config array
   media: vimc: scaler: Rename vic_sca_pad enum to vimc_scaler_pad
   media: vimc: Centralize subdev internal_ops initialization
   media: vimc: Initialize subdev active state
   media: vimc: sensor: Use subdev active state
   media: vimc: debayer: Use subdev active state
   media: vimc: scaler: Use subdev active state


Thank you. Applied the series to

https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git/log/?h=vimc

I will send pull request to Mauro in a week.

thanks,
-- Shuah





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux