Hi Laurent,
On Thu, Apr 25, 2024 at 02:57:33AM +0300, Laurent Pinchart wrote:
> The .init_state() operations of the debayer and sensor entities iterate
> over the entity's pads. In practice, the iteration covers a single pad
> only. Access the pad directly and remove the loops.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/test-drivers/vimc/vimc-debayer.c | 9 +++------
> drivers/media/test-drivers/vimc/vimc-sensor.c | 10 +++-------
> 2 files changed, 6 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/media/test-drivers/vimc/vimc-debayer.c b/drivers/media/test-drivers/vimc/vimc-debayer.c
> index d72ed086e00b..e1bf6db73050 100644
> --- a/drivers/media/test-drivers/vimc/vimc-debayer.c
> +++ b/drivers/media/test-drivers/vimc/vimc-debayer.c
> @@ -155,16 +155,13 @@ static int vimc_debayer_init_state(struct v4l2_subdev *sd,
> {
> struct vimc_debayer_device *vdebayer = v4l2_get_subdevdata(sd);
> struct v4l2_mbus_framefmt *mf;
> - unsigned int i;
>
> mf = v4l2_subdev_state_get_format(sd_state, 0);
> *mf = sink_fmt_default;
>
> - for (i = 1; i < sd->entity.num_pads; i++) {
> - mf = v4l2_subdev_state_get_format(sd_state, i);
> - *mf = sink_fmt_default;
> - mf->code = vdebayer->src_code;
> - }
> + mf = v4l2_subdev_state_get_format(sd_state, 1);
You can assign in variable declaration as this is just about obtaining the
appropriate state pointer.
> + *mf = sink_fmt_default;
> + mf->code = vdebayer->src_code;
>
> return 0;
> }
> diff --git a/drivers/media/test-drivers/vimc/vimc-sensor.c b/drivers/media/test-drivers/vimc/vimc-sensor.c
> index 5e34b1aed95e..b535b3ffecff 100644
> --- a/drivers/media/test-drivers/vimc/vimc-sensor.c
> +++ b/drivers/media/test-drivers/vimc/vimc-sensor.c
> @@ -44,14 +44,10 @@ static const struct v4l2_mbus_framefmt fmt_default = {
> static int vimc_sensor_init_state(struct v4l2_subdev *sd,
> struct v4l2_subdev_state *sd_state)
> {
> - unsigned int i;
> + struct v4l2_mbus_framefmt *mf;
>
> - for (i = 0; i < sd->entity.num_pads; i++) {
> - struct v4l2_mbus_framefmt *mf;
> -
> - mf = v4l2_subdev_state_get_format(sd_state, i);
> - *mf = fmt_default;
> - }
> + mf = v4l2_subdev_state_get_format(sd_state, 0);
Ditto.
Up to you though.
Reviewed-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> + *mf = fmt_default;
>
> return 0;
> }
--
Kind regards,
Sakari Ailus
