Hi Kory, Thank you for the patch. On Thu, Jun 20, 2024 at 12:25:43PM +0200, Kory Maincent wrote: > FW_LOADER config only selects the firmware loader API, but we also need > the sysfs_upload symbols for firmware_upload_unregister() and > firmware_upload_register() to function properly. > > Fixes: 7a52ab415b43 ("media: i2c: Add driver for THine THP7312") > Signed-off-by: Kory Maincent <kory.maincent@xxxxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > drivers/media/i2c/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > index c6d3ee472d81..742bc665602e 100644 > --- a/drivers/media/i2c/Kconfig > +++ b/drivers/media/i2c/Kconfig > @@ -679,6 +679,7 @@ config VIDEO_THP7312 > tristate "THine THP7312 support" > depends on I2C > select FW_LOADER > + select FW_UPLOAD > select MEDIA_CONTROLLER > select V4L2_CCI_I2C > select V4L2_FWNODE -- Regards, Laurent Pinchart