Hello, I applied Ricardo's suggestion. And I found a few ways to improve the style. I've also added Ricardo's reviewed-by tag as these are just style changes. --- Changes in v4: - Based on Ricardo's suggestion, only query the min value in uvc_ctrl_set if necessary - Rename is_relative_ptz_ctrl function to uvc_ctrl_is_relative_ptz for consistency - Rename 'relative speed implementation' to 'relative PTZ controls' in comments - Fix indentation of comments - Reduce the length of the new lines to 80 - Link to v3: https://lore.kernel.org/all/cover.1718726777.git.soyer@xxxxxx/ Changes in v3: - Based on Ricardo's suggestion, I squashed the two patches. - Link to v2: https://lore.kernel.org/all/20240405-uvc-fix-relative-ptz-speed-v1-0-c32cdb2a899d@xxxxxxxxxxxxxxxx/ Changes in v2: - Made recommended changes, moved control check to helper function and removed dead code. - Link to v1: https://lore.kernel.org/all/20240326-uvc-relative-ptz-speed-fix-v1-1-453fd5ccfd37@xxxxxxxxxxxxxxxx/ --- John Bauer (1): media: uvcvideo: UVC minimum relative pan/tilt/zoom speed fix. drivers/media/usb/uvc/uvc_ctrl.c | 42 ++++++++++++++++++++++++++------ 1 file changed, 35 insertions(+), 7 deletions(-) -- 2.45.2 Best regards, Gergo Koteles
