Hi Hans, On Mon, Jun 17, 2024 at 11:13:57AM +0200, Hans Verkuil wrote: > On 10/06/2024 12:05, Sakari Ailus wrote: > > cdev_device_del() is the right function to remove a device when > > cdev_device_add() succeeds. If it does not, however, put_device() needs to > > be used instead. Fix this. > > Hmm, this too is due to a revert patch (03/26) removing something that needs > to be reinstated. > > Wouldn't it be better to fold this into 04/26, with a comment in the commit > log of that commit? I agree, I'll fold it there. > > The problem with this commit log is that it suggests that it fixes a bug, > when really it just corrects something introduced by a revert. -- Kind regards, Sakari Ailus