Hi Hans,
Thank you for the review.
On Mon, Jun 17, 2024 at 11:49:54AM +0200, Hans Verkuil wrote:
> On 10/06/2024 12:05, Sakari Ailus wrote:
> > Release all the resources when the media device is released, moving away
> > from the struct v4l2_device used for that purpose. This is done to
> > exemplify the use of the media device's release callback.
> >
> > Switch to container_of_const(), too, while we're changing the code anyway.
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> > ---
> > drivers/media/test-drivers/vimc/vimc-core.c | 15 +++++++++------
> > 1 file changed, 9 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/media/test-drivers/vimc/vimc-core.c b/drivers/media/test-drivers/vimc/vimc-core.c
> > index af127476e920..3e59f8c256c7 100644
> > --- a/drivers/media/test-drivers/vimc/vimc-core.c
> > +++ b/drivers/media/test-drivers/vimc/vimc-core.c
> > @@ -264,13 +264,12 @@ static int vimc_add_subdevs(struct vimc_device *vimc)
> > return 0;
> > }
> >
> > -static void vimc_v4l2_dev_release(struct v4l2_device *v4l2_dev)
> > +static void vimc_mdev_release(struct media_device *mdev)
> > {
> > struct vimc_device *vimc =
> > - container_of(v4l2_dev, struct vimc_device, v4l2_dev);
> > + container_of_const(mdev, struct vimc_device, mdev);
>
> Please don't mix this in. It makes no sense here since vimc is never
> const. Such a change doesn't belong in this series. So just leave it
> at container_of and update the commit log.
Ok, I can remove it.
I also posted a patch to address the matter in container_of()
documentation. Let's see.
>
> With that change you can add my:
>
> Acked-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>
Thank you!
--
Kind regards,
Sakari Ailus
