RE: [v4l-utils] utils: media-ctl: Install media-ctl header and library files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Laurent,

Thank you for your quick response. Please see my below inline response.

> -----Original Message-----
> From: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Sent: Friday, June 14, 2024 3:35 PM
> To: Gandhi, Neel <neel.gandhi@xxxxxxx>
> Cc: linux-media@xxxxxxxxxxxxxxx; hverkuil@xxxxxxxxx; sakari.ailus@xxxxxx; Hatle,
> Mark <mark.hatle@xxxxxxx>; Allagadapa, Varunkumar
> <varunkumar.allagadapa@xxxxxxx>; Sagar, Vishal <vishal.sagar@xxxxxxx>
> Subject: Re: [v4l-utils] utils: media-ctl: Install media-ctl header and library files
> 
> Hi Neel,
> 
> Thank you for the patch.
> 
> On Fri, Jun 14, 2024 at 12:21:20PM +0530, Neel Gandhi wrote:
> > Install mediactl and v4l2subdev header and library files, which may be
> > required by 3rd party applications to populate and control v4l2subdev
> > device node tree
> 
> We haven't done so because the API of those libraries is currently internal, and
> not guaranteed to be stable.
> 

So, if one's application is developed based on those libraries, then is there any alternative solution for it?

As in the prior versions of v4l-utils package, those libraries are available to use but it was removed from v1.25+ onwards (from meson related changes in c2b91b9c3853b2cbcbe170a542864a3147d179ee commitID). We're using yocto scarthgap, which is using v1.26.

> > Signed-off-by: Neel Gandhi <neel.gandhi@xxxxxxx>
> > ---
> >  utils/media-ctl/meson.build | 28 +++++++++++++++++++++-------
> >  1 file changed, 21 insertions(+), 7 deletions(-)
> >
> > diff --git a/utils/media-ctl/meson.build b/utils/media-ctl/meson.build
> > index 3a7b0c9a..40669b4c 100644
> > --- a/utils/media-ctl/meson.build
> > +++ b/utils/media-ctl/meson.build
> > @@ -3,14 +3,24 @@ libmediactl_sources = files(
> >      'mediactl-priv.h',
> >  )
> >
> > +libmediactl_api = files(
> > +    'mediactl.h',
> > +    'v4l2subdev.h',
> > +)
> > +
> > +install_headers(libmediactl_api, subdir: 'mediactl')
> > +
> >  libmediactl_deps = [
> >      dep_libudev,
> >  ]
> >
> > -libmediactl = static_library('mediactl',
> > -                             libmediactl_sources,
> > -                             dependencies : libmediactl_deps,
> > -                             include_directories : v4l2_utils_incdir)
> > +libmediactl = library('mediactl',
> > +                      libmediactl_sources,
> > +                      soversion: '0',
> > +                      version: '0.0.0',
> > +                      install : true,
> > +                      dependencies : libmediactl_deps,
> > +                      include_directories : v4l2_utils_incdir)
> >
> >  dep_libmediactl = declare_dependency(link_with : libmediactl)
> >
> > @@ -18,9 +28,13 @@ libv4l2subdev_sources = files('libv4l2subdev.c')
> > libv4l2subdev_sources += media_bus_format_names_h
> > libv4l2subdev_sources += media_bus_format_codes_h
> >
> > -libv4l2subdev = static_library('v4l2subdev',
> > -                               libv4l2subdev_sources,
> > -                               include_directories : v4l2_utils_incdir)
> > +libv4l2subdev = library('v4l2subdev',
> > +                        libv4l2subdev_sources,
> > +                        soversion: '0',
> > +                        version: '0.0.0',
> > +                        install : true,
> > +                        dependencies : dep_libmediactl,
> > +                        include_directories : v4l2_utils_incdir)
> >
> >  dep_libv4l2subdev = declare_dependency(link_with : libv4l2subdev)
> >
> 
> --
> Regards,
> 
> Laurent Pinchart

Thanks & Regards,

Neel Gandhi




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux