On Wed, Jun 12, 2024 at 2:10 PM Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> wrote: > > Hi Hans, > > Just read this discussion, too... > > On Wed, Jun 12, 2024 at 12:08:49PM +0200, Hans de Goede wrote: > > Hi, > > > > On 6/6/24 8:12 PM, Hans de Goede wrote: > > > Hi, > > > > > > +To: Rafael since this was Cc-ed to linux-acpi but never send > > > to Rafael directly. > > > > > > Rafael this fixes a crash in 6.10-rc1 for some users and is necessary > > > to make the cameras work on the Dell XPS 13 plus 9320 . > > > > > > On 5/28/24 7:09 PM, Hans de Goede wrote: > > >> Hi Sakari, > > >> > > >> On 5/28/24 10:44 AM, Sakari Ailus wrote: > > >>> Ignore camera related graph port nodes on Dell XPS 9320. They data in BIOS > > >>> is buggy, just like it is for Dell XPS 9315. The corresponding software > > >>> nodes are created by the ipu-bridge. > > >>> > > >>> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > >>> --- > > >>> Hi, > > >>> > > >>> Could you test this and see whether it fixes the warning? > > >>> > > >>> The camera might work with this change, too. > > >> > > >> Thank you I just received a Dell XPS 13 plus 9320 myself to use > > >> for VSC testing and I can confirm that with this patch 6.10.0-rc1 > > >> works, including giving a picture with the libcamera software ISP + > > >> 3 small libcamera patches. > > > > > > I forgot to add: > > > > > > Tested-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > > > I just hit the same problem on another Dell laptop. It seems that > > all Dell laptops with IPU6 camera from the Tiger Lake, Alder Lake > > and Raptor Lake generations suffer from this problem. > > > > So instead of playing whack a mole with DMI matches we should > > simply disable ACPI MIPI DISCO support on all Dell laptops > > with those CPUs. I'm preparing a fix for this to replace > > the DMI matching now. > > DisCo for Imaging support shouldn't be dropped on these systems, and this > isn't what your patch does either. Instead the ACPI graph port nodes (as > per Linux specific definitions) are simply dropped, i.e. this isn't related > to DisCo for Imaging at all. So it looks like the changelog of that patch could be improved, right?
