Hello Hans, Thank you for your review. > -----Original Message----- > From: Hans Verkuil <hverkuil@xxxxxxxxx> > Sent: Friday, May 31, 2024 8:02 PM > To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開) > <yuji2.ishikawa@xxxxxxxxxxxxx>; Laurent Pinchart > <laurent.pinchart@xxxxxxxxxxxxxxxx>; Mauro Carvalho Chehab > <mchehab@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski > <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; Rafael J . > Wysocki <rafael.j.wysocki@xxxxxxxxx>; iwamatsu nobuhiro(岩松 信洋 ○ＤＩ > ＴＣ□ＤＩＴ○ＯＳＴ) <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> > Cc: linux-media@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v10 0/6] Add Toshiba Visconti Video Input Interface driver > > Hi Yuji, > > On 24/04/2024 04:42, Yuji Ishikawa wrote: > > This series is the Video Input Interface driver for Toshiba's ARM SoC, > > Visconti. > > This provides DT binding documentation, device driver, documentation > > and MAINTAINER files. > > > > A visconti VIIF driver instance exposes > > 1 media control device file, 3 video device files for capture and 2 > > video device files for controlling image signal processor. > > Detailed HW/SW are described in documentation directory. > > The VIIF hardware has CSI2 receiver, > > image signal processor and DMAC inside. > > The subdevice for image signal processor provides vendor specific V4L2 > > controls. > > > > The device driver depends on two other drivers under development; > > clock framework driver and IOMMU driver. > > Corresponding features will be added later. > > > > Best regards, > > Yuji > > I commented on patches 3 and 4. > > I also ran this series through my build scripts, and it did found a few small > warnings: > > kerneldoc: WARNINGS: > > drivers/media/platform/toshiba/visconti/viif.h:386: warning: Excess struct > member 'subdevs' description in 'viif_device' > drivers/media/platform/toshiba/visconti/viif.h:386: warning: Excess struct > member 'asds' description in 'viif_device' > drivers/media/platform/toshiba/visconti/viif.h:386: warning: Excess struct > member 'sd' description in 'viif_device' > drivers/media/platform/toshiba/visconti/viif_common.h:30: warning: Function > parameter or struct member 'bayer_pattern' not described in 'viif_mbus_format' > drivers/media/platform/toshiba/visconti/viif_common.h:30: warning: Function > parameter or struct member 'is_bayer' not described in 'viif_mbus_format' > > Should be trivial to fix. > I'll fix kerneldoc comments. > Regards, > > Hans > Best regards, Yuji
