Hi Clemens, Thanks for the review. On Thursday 25 November 2010 10:33:02 Clemens Ladisch wrote: > Laurent Pinchart wrote: > > +struct media_device { > > ... > > + u8 model[32]; > > + u8 serial[40]; > > + u8 bus_info[32]; > > All drivers and userspace applications have to treat this as char[], so > why u8[]? Good question. I've copied the V4L2 practice of using u8 (or __u8) for fixed- length strings in structures. I can't think of any reason for that. I will replace u8 with char unless someone comes up with a good reason to keep u8. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html