Hi Wentong,
On Mon, Jun 03, 2024 at 04:26:12PM +0800, Wentong Wu wrote:
> Prior to the ongoing command privacy is on, it would return -1 to
> indicate the current privacy status, and the ongoing command would
> be well executed by firmware as well, so this is not error. This
> patch changes its behavior to notify privacy on directly by V4L2
> privacy control instead of reporting error.
>
> Fixes: 29006e196a56 ("media: pci: intel: ivsc: Add CSI submodule")
> Reported-by: Hao Yao <hao.yao@xxxxxxxxx>
> Signed-off-by: Wentong Wu <wentong.wu@xxxxxxxxx>
> Tested-by: Jason Chen <jason.z.chen@xxxxxxxxx>
> ---
> drivers/media/pci/intel/ivsc/mei_csi.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/intel/ivsc/mei_csi.c b/drivers/media/pci/intel/ivsc/mei_csi.c
> index 89b582a221ab..004ebab0b814 100644
> --- a/drivers/media/pci/intel/ivsc/mei_csi.c
> +++ b/drivers/media/pci/intel/ivsc/mei_csi.c
> @@ -190,7 +190,11 @@ static int mei_csi_send(struct mei_csi *csi, u8 *buf, size_t len)
>
> /* command response status */
> ret = csi->cmd_response.status;
> - if (ret) {
> + if (ret == -1) {
> + /* notify privacy on instead of reporting error */
> + ret = 0;
> + v4l2_ctrl_s_ctrl(csi->privacy_ctrl, CSI_PRIVACY_ON);
s/CSI_PRIVACY_ON/1/
> + } else if (ret) {
> ret = -EINVAL;
> goto out;
> }
--
Kind regards,
Sakari Ailus
