Hi Hans, Sebastian, On 18/03/24 20:11, Hans Verkuil wrote: > On 18/03/2024 2:43 pm, Hans Verkuil wrote: >> On 09/03/2024 4:15 pm, Sebastian Fricke wrote: [...] >> The other two patches are OK, but since a v7 is needed anyway, I'll >> add a few comments to patch 3/3 as well. > > Actually, patch 3/3 has some issues as well, esp. regarding the selection > API. > > Note that I recommend that you test the selection API before posting a > v7, since it is clear that it has never been used since it currently > always returns -EINVAL. > > Regards, > > Hans Just wanted to check if the latest series [1] looks ok to pull in as I had fixed the cropping related issues and implemented API to export reference JPEG tables as part of v4l2-jpeg.c itself as suggested by Hans along with kernel-doc upgrades. There has been no major changes in v4l2-jpeg or jpeg driver (e5010-jpeg-enc) related code since last 3 revisions as no comments were received, so just wanted to get your opinion on this. [1]: https://lore.kernel.org/all/20240604105402.2258395-1-devarsht@xxxxxx/#r Regards Devarsh
