On Thu, May 30, 2024 at 10:48:10PM +0530, Devarsh Thakkar wrote: > From: Daniel Latypov <dlatypov@xxxxxxxxxx> > > Add basic test coverage for files that don't require any config options: > * part of math.h (what seem to be the most commonly used macros) > * gcd.c > * lcm.c > * int_sqrt.c > * reciprocal_div.c > (Ignored int_pow.c since it's a simple textbook algorithm.) > > These tests aren't particularly interesting, but they > * provide short and simple examples of parameterized tests > * provide a place to add tests for any new files in this dir > * are written so adding new test cases to cover edge cases should be > easy > * looking at code coverage, we hit all the branches in the .c files ... > +#include <kunit/test.h> > +#include <linux/gcd.h> > +#include <linux/lcm.h> > +#include <linux/reciprocal_div.h> Really, you ignored my comment a second (?) time? This is road to nowhere. You need to update the inclusion bloc in accordance with IWYU principle. I see a few headers are missing. -- With Best Regards, Andy Shevchenko
