Hi Krzysztof, On Tue, May 28, 2024 at 11:46:00AM +0200, Krzysztof Kozlowski wrote: > On 28/05/2024 11:22, Sakari Ailus wrote: > > Hi Krzysztof, > > > > On Mon, May 27, 2024 at 09:04:38PM +0200, Krzysztof Kozlowski wrote: > >> On 21/05/2024 18:29, Sylvain Petinot wrote: > >>> Add devicetree bindings Documentation for ST VD56G3 & ST VD66GY camera > >>> sensors. Update MAINTAINERS file. > >>> > >>> Signed-off-by: Sylvain Petinot <sylvain.petinot@xxxxxxxxxxx> > >> > >> > >>> diff --git a/MAINTAINERS b/MAINTAINERS > >>> index ef6be9d95143..554e6861425b 100644 > >>> --- a/MAINTAINERS > >>> +++ b/MAINTAINERS > >>> @@ -20885,6 +20885,15 @@ S: Maintained > >>> F: Documentation/hwmon/stpddc60.rst > >>> F: drivers/hwmon/pmbus/stpddc60.c > >>> > >>> +ST VD56G3 DRIVER > > > > I might add this is a sensor, i.e. "ST VD653G IMAGE SENSOR DRIVER". > > > >>> +M: Benjamin Mugnier <benjamin.mugnier@xxxxxxxxxxx> > >>> +M: Sylvain Petinot <sylvain.petinot@xxxxxxxxxxx> > >>> +L: linux-media@xxxxxxxxxxxxxxx > >>> +S: Maintained > >>> +T: git git://linuxtv.org/media_tree.git > >> > >> This is a friendly reminder during the review process. > >> > >> It seems my or other reviewer's previous comments were not fully > >> addressed. Maybe the feedback got lost between the quotes, maybe you > >> just forgot to apply it. Please go back to the previous discussion and > >> either implement all requested changes or keep discussing them. > > > > The above MAINTAINERS entry is roughly in line with what else we have for > > the Media tree. I'm in favour of listing the people who would look after > > the driver, not just those who merge the patches (or even send PRs to > > Linus). > > I did not propose to drop the entry. > > > > > In other words, I think the above entry is fine as-is. > > I propose to drop duplicated, redundant git entry. Maintainer of this Ah, I agree, that makes sense. > driver does not have access to git tree and the git tree is already > explained in media subsystem entry. If you ever update the git tree, you > need to update 100 driver entries which is meaningless... -- Regards, Sakari Ailus
