Hi Niklas,
On Mon, May 27, 2024 at 3:24 PM Niklas Söderlund
<niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> Add support for R-Car V4M. The V4M uses the ISP Channel Selector as its
> only possible video input source. Even tho V4M is not a Gen3 board the
> VIN interface is very close to the one found on the V3U, for this reason
> mark it as a Gen3 model internally.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
Thanks for your patch!
> --- a/drivers/media/platform/renesas/rcar-vin/rcar-core.c
> +++ b/drivers/media/platform/renesas/rcar-vin/rcar-core.c
> @@ -1292,6 +1292,15 @@ static const struct rvin_info rcar_info_r8a779g0 = {
> .max_height = 4096,
> };
>
> +static const struct rvin_info rcar_info_r8a779h0 = {
> + .model = RCAR_GEN3,
> + .use_mc = true,
> + .use_isp = true,
> + .nv12 = true,
> + .max_width = 4096,
> + .max_height = 4096,
> +};
Unless I misread, this structure is identical to the existing rcar_info_r8a779a0
and rcar_info_r8a779g0 structures? Perhaps deduplicate and rename
to rcar_info_gen4?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
