Re: [PATCH] dt-bindings: media: renesas,csi2: Add binding for V4M

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 27/05/2024 18:35, Conor Dooley wrote:
> On Mon, May 27, 2024 at 03:20:46PM +0200, Niklas Söderlund wrote:
>> Document support for the CSI-2 module in the Renesas V4M (r8a779h0) SoC.
>>
>> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> 
> Another one not in a series, this should be with:
> https://lore.kernel.org/all/20240527133221.1688830-8-niklas.soderlund+renesas@xxxxxxxxxxxx/

Niklas,

So you send three or four separate one-patch-sets for single compatible,
without any links or hints about driver submission which apparently goes
in parallel with impression of undocumented compatibles.

That's not the way.

First, if you insist on sending this separate for whatever reason, this
should have been ONE PATCHSET with cover letter (explanation + links to
users). There are no links: neither here, nor in driver submission.

Second, bindings GO WITH DRIVERS, so sending drivers without bindings is
posting undocumented compatibles. I would reject such patches to my
subsystem, because checkpatch would complain that you have undocumented
bindings.

Please resend entire series together - drivers or bindings. For every
separate submission, e.g. DTS separate from the binding which is quite
expected for media, network and USB, please always link to the binding.


Best regards,
Krzysztof





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux