On 11/23/2010 09:39 PM, Jarod Wilson wrote: > I get warnings about casting to and from pointers and integers of > different sizes w/current code, this silences them. > > Signed-off-by: Jarod Wilson <jarod@xxxxxxxxxx> Looks good, and works. Acked-by: Richard Röjfors <richard.rojfors@xxxxxxxxxxxxxx> > --- > drivers/media/video/timblogiw.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/video/timblogiw.c b/drivers/media/video/timblogiw.c > index 48989e5..4da3625 100644 > --- a/drivers/media/video/timblogiw.c > +++ b/drivers/media/video/timblogiw.c > @@ -148,7 +148,9 @@ static void timblogiw_dma_cb(void *data) > > static bool timblogiw_dma_filter_fn(struct dma_chan *chan, void *filter_param) > { > - return chan->chan_id == (int)filter_param; > + int chan_id = *(int *)filter_param; > + > + return chan->chan_id == chan_id; > } > > /* IOCTL functions */ > @@ -670,7 +672,7 @@ static int timblogiw_open(struct file *file) > > /* find the DMA channel */ > fh->chan = dma_request_channel(mask, timblogiw_dma_filter_fn, > - (void *)lw->pdata.dma_channel); > + (void *)(unsigned long)lw->pdata.dma_channel); > if (!fh->chan) { > dev_err(&vdev->dev, "Failed to get DMA channel\n"); > kfree(fh); -- ============================================= Richard Röjfors Software Architect Pelagicore AB Ekelundsgatan 4, 6tr, SE-411 18 Gothenburg, Sweden Mobile: +46 (0)708 88 97 91 E-Mail: richard.rojfors@xxxxxxxxxxxxxx ============================================= === NOTE === The information contained in this E-mail message is intended only for use of the individual or entity named above. If the reader of this message is not the intended recipient, or the employee or agent responsible to deliver it to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. ============= -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html