On Thu, May 23, 2024 at 11:53:56AM +0300, Laurent Pinchart wrote: > On Tue, Mar 05, 2024 at 06:50:15AM +0000, Sakari Ailus wrote: > > On Tue, Mar 05, 2024 at 12:59:07AM +0200, Laurent Pinchart wrote: > > > On Mon, Mar 04, 2024 at 08:51:25PM +0200, Sakari Ailus wrote: > > > > MEDIA_CONTROLLER has no dependencies and VIDEO_V4L2_SUBDEV_API depends on > > > > it. Select MEDIA_CONTROLLER instead of depending on it. This way Kconfig > > > > options elsewhere do only need to select VIDEO_V4L2_SUBDEV_API, not both. > > > > > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > > > --- > > > > Mostly untested but seems reasonable. MEDIA_CONTROLLER has no dependencies > > > > anymore. > > > > > > It seems reasonable to me too, but I think it would make sense to drop > > > in the same patch the manual selection of MEDIA_CONTROLLER for the > > > Kconfig symbols that already select VIDEO_V4L2_SUBDEV_API. > > > > This should be done, yes, but I'd add a separate patch for it: this one > > doesn't require changes elsewhere as such, just enables making them. Same > > for the other, few users that depend on MEDIA_CONTROLLER, they need to be > > converted, too. > > I'm OK with a separate patch, but can you send one ? :-) Yes, a bit later on. This is worth merging without such a change as also new drivers will need to select both options. -- Sakari Ailus
