Hi Sergio, On Mon, Nov 22, 2010 at 08:53:53PM +0100, ext Sergio Aguirre wrote: > (Resending...) > > Hi, > > These are some patches to make these operations more generic: > - Clock control is being controlled in a very crude manner by > subdevices, it should be centralized in isp.c. > - LSC prefetch wait check is reading a main ISP register, so move > it to isp.c > - Abstract SBL busy check: we don't want a submodule thinkering > with main ISP registers. That should be done in the main isp.c > > Also, remove main ISP register dump from CSI2 specific dump. We > should be using isp_print_status if we'll like to know main ISP > regdump. > > Comments are welcome. More cleanups for better subdevice isolation > are on the way. > > Regards, > Sergio > > Changelog: > v2: > - Improved logic in isp subdevs clock control (Thanks David Cohen) > - Renamed ispccdc_lsc_wait_prefetch -> isp_ccdc_* to be clear on > function declaration new location (isp.c) (Thanks David and Laurent) This version looks good for me. Regards, David Cohen > > v1: > - Initial version > > Sergio Aguirre (4): > omap3isp: Abstract isp subdevs clock control > omap3isp: Move CCDC LSC prefetch wait to main isp code > omap3isp: sbl: Abstract SBL busy check > omap3isp: csi2: Don't dump ISP main registers > > drivers/media/video/isp/isp.c | 87 ++++++++++++++++++++++++++++++++++ > drivers/media/video/isp/isp.h | 16 ++++++ > drivers/media/video/isp/ispccdc.c | 42 ++--------------- > drivers/media/video/isp/ispcsi2.c | 7 --- > drivers/media/video/isp/isppreview.c | 6 +-- > drivers/media/video/isp/ispresizer.c | 6 +-- > 6 files changed, 111 insertions(+), 53 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
