Hi Bryan Thanks for your review On Fri, 10 May 2024 at 01:56, Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> wrote: > > On 10/05/2024 00:35, Bryan O'Donoghue wrote: > > I think these structures should just have the "[1] -> []" conversion > > done and be retained instead. > > They won't have the same sizeof() then so ignore that thought. > > I still would suggest dropping the `something[1]` in favour of > `something` because these structures document the protocol between host > and firmware and therefore are useful even if unused in the code. The structures will be in the git log for the rest of the days. So if someone has to use them, they can recover them from there. Right now, they are not used and they are triggering a warning. I would argue that untested code is broken code. I'd rather remove the code. > > --- > bod -- Ricardo Ribalda
