Hi Volodymyr, Thank you for your patch. On 5/16/24 18:41, Volodymyr Kharuk wrote: > Add V4L2_CID_CAMERA_TRIGGER_MODE as a menu item control to set > trigger mode. Also proposed some standard modes. > Another item is V4L2_CID_CAMERA_TRIGGER as a button to send > trigger in V4L2_TRIGGER_MODE_INTERNAL mode. > > Signed-off-by: Volodymyr Kharuk <vkh@xxxxxxxxxxx> This is very interesting. As I understand this control allows to change what triggers sensor acquisition. May I ask what the different modes do ? We had a discussion previously with Laurent, Sakari and Dave (adding him as cc btw) about a "slave mode" control [1] for the vgxy61, is it something similar to the trigger mode ? [1] https://lore.kernel.org/linux-media/c610a2c9-31b1-1950-00fa-a6b3fd3517a1@xxxxxxxxxxx/ > --- > include/uapi/linux/v4l2-controls.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h > index 99c3f5e99da7..7901f40a1bd8 100644 > --- a/include/uapi/linux/v4l2-controls.h > +++ b/include/uapi/linux/v4l2-controls.h > @@ -1087,6 +1087,14 @@ enum v4l2_auto_focus_range { > > #define V4L2_CID_HDR_SENSOR_MODE (V4L2_CID_CAMERA_CLASS_BASE+36) > > +#define V4L2_CID_CAMERA_TRIGGER (V4L2_CID_CAMERA_CLASS_BASE + 37) > +#define V4L2_CID_CAMERA_TRIGGER_MODE (V4L2_CID_CAMERA_CLASS_BASE + 38) > +enum v4l2_trigger_mode { > + V4L2_TRIGGER_MODE_CONTINUOUS = 0, > + V4L2_TRIGGER_MODE_INTERNAL = 1, > + V4L2_TRIGGER_MODE_EXTERNAL = 2, > +}; > + > /* FM Modulator class control IDs */ > > #define V4L2_CID_FM_TX_CLASS_BASE (V4L2_CTRL_CLASS_FM_TX | 0x900) -- Regards, Benjamin
