Hi Laurent and Sergio, On Mon, Nov 22, 2010 at 04:31:09PM +0100, ext Aguirre, Sergio wrote: > > > > -----Original Message----- > > From: Laurent Pinchart [mailto:laurent.pinchart@xxxxxxxxxxxxxxxx] > > Sent: Saturday, November 20, 2010 11:31 AM > > To: David Cohen > > Cc: Aguirre, Sergio; linux-media@xxxxxxxxxxxxxxx > > Subject: Re: [omap3isp RFC][PATCH 0/4] Improve inter subdev interaction > > > > Hi David, > > > > On Saturday 20 November 2010 12:44:27 David Cohen wrote: > > > On Sat, Nov 20, 2010 at 12:23:47AM +0100, ext Sergio Aguirre wrote: > > > > Hi, > > > > > > > > These are some patches to make these operations more generic: > > > > - Clock control is being controlled in a very crude manner by > > > > > > > > subdevices, it should be centralized in isp.c. > > > > > > > > - LSC prefetch wait check is reading a main ISP register, so move > > > > > > > > it to isp.c > > > > > > > > - Abstract SBL busy check: we don't want a submodule thinkering > > > > > > > > with main ISP registers. That should be done in the main isp.c > > > > > > > > Also, remove main ISP register dump from CSI2 specific dump. We > > > > should be using isp_print_status if we'll like to know main ISP > > > > regdump. > > > > > > > > Comments are welcome. More cleanups for better subdevice isolation > > > > are on the way. > > > > > > Your patches are fine for me. I sent you some comments, but they are > > > opitional and it's up to you to decide what to do. :) > > > You can copy linux-omap@ as well in future patches. > > David and Laurent, > > I appreciate a lot your review time and comments. > > > > > I will try to submit the next version of the omap3isp driver for upstream > > review, either at the end of the weekend or on Monday. I will cross-post > > the > > driver to linux-media, linux-omap and LKML. Let's be ready to defend the > > media > > controller and the omap3isp driver :-) > > Yeah! :) > > > > > Until then let's not spam linux-omap with patches for a driver they don't > > know > > about. > > Agreed. Me too. :) Br, David Cohen > > Regards, > Sergio > > > > > -- > > Regards, > > > > Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
