On 07/05/2024 17:27, Ricardo Ribalda wrote:
-struct hfi_sys_get_property_pkt {
+struct hfi_sys_get_version_pkt {
struct hfi_pkt_hdr hdr;
- u32 num_properties;
Disagree with the structure name change - the structure describes the
packet which in this case is a get property packet. The data field
identifies the packet to the firmware.
If I were to end up reading kernel code and firmware code it is easier
on the programmer to match both ends of the protocol with a common
namespace.
Please retain the name of the packet `hfi_sys_get_property_pkt` and the
existing `num_countsathing` in this driver keeping `num_properites`
---
bod
