Re: [PATCH v2 12/18] media: venus: Refactor struct hfi_session_get_property_pkt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/05/2024 17:27, Ricardo Ribalda wrote:
-	u32 num_properties;
-	u32 data[1];
+	u32 one;
+	u32 data;

The conversion of `data[1]` to plain `data` is fine but, the conversion of `num_properties` to `one` doesn't fit the naming convention of this code which uses `num_something` extensively.

Please retain the name `num_properties` for that reason.

Then add.

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux