Hi Ricardo,
Thank you for the patch.
On Thu, May 09, 2024 at 05:05:55PM +0000, Ricardo Ribalda wrote:
> The current code does not return anything to the user.
>
> Although the code looks a bit dangerous (using a pointer without
> checking if it is valid), it should be fine. The code validates that
I think you meant s/code/core/
> sel->pad has a valid value.
>
> Fix the following smatch error:
> drivers/media/i2c/hi846.c:1854 hi846_get_selection() warn: statement has no effect 31
>
> Fixes: e8c0882685f9 ("media: i2c: add driver for the SK Hynix Hi-846 8M pixel camera")
> Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> While running media-ci on the last patches there was a new sparse
> warning:
> https://gitlab.freedesktop.org/linux-media/users/patchwork/-/jobs/58524338/artifacts/external_file/junit/test-smatch.log.txt
> ---
> drivers/media/i2c/hi846.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/hi846.c b/drivers/media/i2c/hi846.c
> index 9c565ec033d4..52d9ca68a86c 100644
> --- a/drivers/media/i2c/hi846.c
> +++ b/drivers/media/i2c/hi846.c
> @@ -1851,7 +1851,7 @@ static int hi846_get_selection(struct v4l2_subdev *sd,
> mutex_lock(&hi846->mutex);
> switch (sel->which) {
> case V4L2_SUBDEV_FORMAT_TRY:
> - v4l2_subdev_state_get_crop(sd_state, sel->pad);
> + sel->r = *v4l2_subdev_state_get_crop(sd_state, sel->pad);
> break;
> case V4L2_SUBDEV_FORMAT_ACTIVE:
> sel->r = hi846->cur_mode->crop;
>
> ---
> base-commit: 48259b90973718d2277db27b5e510f0fe957eaa0
> change-id: 20240509-fix-hi846-c3d77768622e
--
Regards,
Laurent Pinchart
