Re: Race condition between v4l2_open() and video_unregister_device()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday, November 22, 2010 01:23:39 Laurent Pinchart wrote:
> Hi Hans,
> 
> I believe you've introduced a race condition in commit 
> dd0daf2a6fb6bec436a3ef68bd585ea09a2a54b7
> 
> v4l2-dev: remove unnecessary lock around atomic clear_bit
> 
> By removing the mutex_lock/unlock around clear_bit, you're allowing 
> device_unregister() to race with v4l2_open(). The device can be unregistered 
> between the video_devdata() and video_get() calls.
> 
> Could you confirm my analysis ?

Yes, that's correct. Good catch.

Regards,

	Hans

-- 
Hans Verkuil - video4linux developer - sponsored by Cisco
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux