Hi Jonathan, I forgot to answer one of your comments. On Wednesday 17 November 2010 01:31:15 Jonathan Corbet wrote: [snip] > > +static unsigned int media_poll(struct file *filp, > > + struct poll_table_struct *poll) > > +{ > > + struct media_devnode *mdev = media_devnode_data(filp); > > + > > + if (!mdev->fops->poll || !media_devnode_is_registered(mdev)) > > + return DEFAULT_POLLMASK; > > + return mdev->fops->poll(filp, poll); > > +} > > If it's not registered, I would expect poll() to return an error. Agreed. I'll return POLLERR | POLLHUP in that case. Is that fine with you ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html