Re: [PATCH] media: videobuf2: core: Drop unneeded forward declaration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 6, 2024 at 2:40 AM Laurent Pinchart
<laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> wrote:
>
> The static __enqueue_in_driver() function is forward-declared
> needlessly, as it isn't called before its definition. Drop the forward
> declaration.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> ---
>  drivers/media/common/videobuf2/videobuf2-core.c | 1 -
>  1 file changed, 1 deletion(-)
>

Reviewed-by: Tomasz Figa <tfiga@xxxxxxxxxxxx>

Best,
Tomasz

> diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b/drivers/media/common/videobuf2/videobuf2-core.c
> index 358f1fe42975..0217392fcc0d 100644
> --- a/drivers/media/common/videobuf2/videobuf2-core.c
> +++ b/drivers/media/common/videobuf2/videobuf2-core.c
> @@ -199,7 +199,6 @@ module_param(debug, int, 0644);
>  })
>
>  static void __vb2_queue_cancel(struct vb2_queue *q);
> -static void __enqueue_in_driver(struct vb2_buffer *vb);
>
>  static const char *vb2_state_name(enum vb2_buffer_state s)
>  {
>
> base-commit: e695668af8523b059127dfa8b261c76e7c9cde10
> --
> Regards,
>
> Laurent Pinchart
>





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux