On 06/05/2024 14:19, Vikash Garodia wrote: > On 4/30/2024 9:04 PM, Marc Gonzalez wrote: > >> From: Pierre-Hugues Husson <phhusson@xxxxxxxxxx> >> >> Add the missing bits for msm8998 support. >> >> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> >> Signed-off-by: Pierre-Hugues Husson <phhusson@xxxxxxxxxx> >> Signed-off-by: Marc Gonzalez <mgonzalez@xxxxxxxxxx> >> --- >> drivers/media/platform/qcom/venus/core.c | 42 ++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 42 insertions(+) >> >> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c >> index ce206b7097541..42e0c580e093d 100644 >> --- a/drivers/media/platform/qcom/venus/core.c >> +++ b/drivers/media/platform/qcom/venus/core.c >> @@ -587,6 +587,47 @@ static const struct venus_resources msm8996_res = { >> .fwname = "qcom/venus-4.2/venus.mbn", >> }; >> >> +static const struct freq_tbl msm8998_freq_table[] = { >> + { 1944000, 520000000 }, /* 4k UHD @ 60 (decode only) */ >> + { 972000, 520000000 }, /* 4k UHD @ 30 */ >> + { 489600, 346666667 }, /* 1080p @ 60 */ >> + { 244800, 150000000 }, /* 1080p @ 30 */ >> + { 108000, 75000000 }, /* 720p @ 30 */ >> +}; > > Can we reuse the table from 8996 since they are exactly same ? Now that I have squinted closer at the downstream code, I see that the tables should actually be different... Will spin a v3. Regards