Em Wed, 01 May 2024 13:08:09 +0000
Ricardo Ribalda <ribalda@xxxxxxxxxxxx> escreveu:
> The driver can only match the device vide the DT table, so the table
> should always be used, of_match_ptr does not make sense here.
>
> Fixes:
> drivers/media/platform/broadcom/bcm2835-unicam.c:2724:34: warning: ‘unicam_of_match’ defined but not used [-Wunused-const-variable=]
Be careful here: Fixes: <patch> is a tag used by stable people to
identify if a patch needs to be backported. Using a Fixes: may cause
such scripts to break.
(it caused a problem on my apply patch script, as it does reorder
fixes tag).
No need to resend it, as I can fix it when applying, but next time
please use something like:
It fixes this warning:
drivers/media/platform/broadcom/bcm2835-unicam.c:2724:34: warning: ‘unicam_of_match’ defined but not used [-Wunused-const-variable=]
(or some other similar word that won't be using a defined meta tag
with a different meaning).
Regards,
Mauro
>
> Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
> ---
> drivers/media/platform/broadcom/bcm2835-unicam.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/media/platform/broadcom/bcm2835-unicam.c
> index bd2bbb53070e..c590e26fe2cf 100644
> --- a/drivers/media/platform/broadcom/bcm2835-unicam.c
> +++ b/drivers/media/platform/broadcom/bcm2835-unicam.c
> @@ -2733,7 +2733,7 @@ static struct platform_driver unicam_driver = {
> .driver = {
> .name = UNICAM_MODULE_NAME,
> .pm = pm_ptr(&unicam_pm_ops),
> - .of_match_table = of_match_ptr(unicam_of_match),
> + .of_match_table = unicam_of_match,
> },
> };
>
>
