On 30/04/2024 01:19, Bryan O'Donoghue wrote: > On 29/04/2024 17:19, Marc Gonzalez wrote: > >> From: Pierre-Hugues Husson <phhusson@xxxxxxxxxx> >> >> Add the missing bits for MSM8998 support. >> >> Signed-off-by: Pierre-Hugues Husson <phhusson@xxxxxxxxxx> >> Signed-off-by: Marc Gonzalez <mgonzalez@xxxxxxxxxx> >> --- >> drivers/media/platform/qcom/venus/core.c | 42 ++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 42 insertions(+) >> >> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c >> index ce206b7097541..42e0c580e093d 100644 >> --- a/drivers/media/platform/qcom/venus/core.c >> +++ b/drivers/media/platform/qcom/venus/core.c >> @@ -587,6 +587,47 @@ static const struct venus_resources msm8996_res = { >> .fwname = "qcom/venus-4.2/venus.mbn", >> }; >> >> +static const struct freq_tbl msm8998_freq_table[] = { >> + { 1944000, 520000000 }, /* 4k UHD @ 60 (decode only) */ >> + { 972000, 520000000 }, /* 4k UHD @ 30 */ >> + { 489600, 346666667 }, /* 1080p @ 60 */ >> + { 244800, 150000000 }, /* 1080p @ 30 */ >> + { 108000, 75000000 }, /* 720p @ 30 */ >> +}; >> + >> +/* >> + * https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blob/caf_migration/kernel.lnx.4.4.r38-rel/arch/arm/boot/dts/qcom/msm8998-vidc.dtsi > > Nice touch. > > Does encoding/decoding work on -next sans interconnect support ? I think > we discussed on IRC it does but I'll ask again just to confirm. (We have no use-case for encoding.) Decoding works, of course. I would not submit a broken feature :) (vp9 2560x1440 59.940fps) decodes at x2 (122s for 240s) (vp9 854x480 29.970fps) decodes at x15 ( 16s for 240s) I find the performance quite decent. Though I would have expected a larger performance ratio: 2560x1440 59.940fps = 221 Mpixel/s 854x480 29.970fps = 12 Mpixel/s If 1440p decodes at x2, 480p should decode at x30 ? Or maybe the bottleneck is elsewhere :) Regards