Hi Hans, On Mon, Apr 29, 2024 at 09:30:37AM +0200, Hans Verkuil wrote: > On 29/04/2024 09:28, Sakari Ailus wrote: > > Hi Laurent, > > > > On Mon, Apr 29, 2024 at 02:20:28AM +0300, Laurent Pinchart wrote: > >> Hi Sakari, > >> > >> Thank you for the patches. > >> > >> On Fri, Apr 26, 2024 at 05:55:35PM +0300, Sakari Ailus wrote: > >>> Hi folks, > >>> > >>> An integer menu isn't a useful control type for conveying the frequency > >>> depending on an external device to the receiver. Instead, in the MEI CSI > >>> driver, just obtain the link frequency from the upsteam sub-device and > >>> pass it on to the receiver. > >>> > >>> The v4l2_get_link_freq() is changed to add support for this and it's > >>> documented as well. > >> > >> Using a control for this seems to be a bit of a hack :-S Wouldn't it fit > >> more nicely in the .get_mbus_config() operation ? That would avoid > >> exposing this to userspace, and would also have the nice advantage that > >> the value could be queried per pad. > > > > Works for me. I also think it's better than using a new control for this > > actually. > > Same for me. As you gathered, I was not very enthusiastic about using a > control for this either. Ack. I guess these are fine to be merged for 6.11 but still backporting to 6.10 should be done. Nothing breaks now as there's a single frequency used right now and that's 400 MHz. -- Regards, Sakari Ailus
