Hi Tomi,
Thank you for the patch.
On Wed, Apr 24, 2024 at 06:39:14PM +0300, Tomi Valkeinen wrote:
> Now that enable/disable_streams operations are available for
> single-stream subdevices too, there's no reason to use the old s_stream
> operation on new drivers. Extend the documentation reflecting this.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> include/media/v4l2-subdev.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
> index 14a3c91cce93..99564a2ef71c 100644
> --- a/include/media/v4l2-subdev.h
> +++ b/include/media/v4l2-subdev.h
> @@ -450,6 +450,15 @@ enum v4l2_subdev_pre_streamon_flags {
> * already started or stopped subdev. Also see call_s_stream wrapper in
> * v4l2-subdev.c.
> *
> + * New drivers should instead implement &v4l2_subdev_pad_ops.enable_streams
> + * and &v4l2_subdev_pad_ops.disable_streams operations, and use
> + * v4l2_subdev_s_stream_helper for the &v4l2_subdev_video_ops.s_stream
> + * operation to support legacy users.
> + *
> + * Drivers should also not call the .s_stream() subdev operation directly,
> + * but use the v4l2_subdev_enable_streams() and
> + * v4l2_subdev_disable_streams() helpers.
> + *
> * @g_pixelaspect: callback to return the pixelaspect ratio.
> *
> * @s_rx_buffer: set a host allocated memory buffer for the subdev. The subdev
--
Regards,
Laurent Pinchart
