On Wed, Apr 24, 2024 at 9:15 PM Tony Luck <tony.luck@xxxxxxxxx> wrote: > > New CPU #defines encode vendor and family as well as model. Got less LoCs, so good change, Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx> See also one nit-pick below. ... > /* Both CHT and MOFD come with ISP2401 */ > +#define IS_ISP2401 __IS_SOCS(INTEL_ATOM_AIRMONT, \ > + INTEL_ATOM_AIRMONT_MID) I would make it one line. -- With Best Regards, Andy Shevchenko