Re: [PATCH] media: venus: fix use after free in vdec_close

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 24/04/2024 08:17, Dikshita Agarwal wrote:
There appears to be a possible use after free with vdec_close().
The firmware will add buffer release work to the work queue through
HFI callbacks as a normal part of decoding. Randomly closing the
decoder device from userspace during normal decoding can incur
a read after free for inst.

Fix it by cancelling the work in vdec_close.

Signed-off-by: Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx>
  drivers/media/platform/qcom/venus/vdec.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c
index 29130a9..56f8a25 100644
--- a/drivers/media/platform/qcom/venus/vdec.c
+++ b/drivers/media/platform/qcom/venus/vdec.c
@@ -1747,6 +1747,7 @@ static int vdec_close(struct file *file)
vdec_pm_get(inst); + cancel_work_sync(&inst->delayed_process_work);

Needs a Fixes tag


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux